Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony 3.0 Upgrade #24

Closed
frodosghost opened this issue Jan 29, 2016 · 3 comments
Closed

Symfony 3.0 Upgrade #24

frodosghost opened this issue Jan 29, 2016 · 3 comments

Comments

@frodosghost
Copy link
Contributor

Yesterday I raised a PR #22, but in using the bundle in Symfony 3 I had to make a few more changes. These changes won't work in the Symfony 2.x branches. This is because of the location of SimplePreAuthenticatorInterface in the files directory.

What is the process of requesting a merge in this instance? I was going to create a new PR, but that would break the 1.2 branch from working with Symfony 2.x.
@glena
Copy link
Contributor

glena commented Jan 29, 2016

Hi @frodosghost,

I just pushed a new branch called 2.x.x-dev.

I really appreciate your contributions, feel free to target the PR to this branch.

Thank you

@frodosghost
Copy link
Contributor Author

Hi @glena,

Not a problem. Raised PR #25 for your review.

@glena
Copy link
Contributor

glena commented Jan 29, 2016

👏 awesome man, so many thanks.

I will review it later today and release v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frodosghost @glena