-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add direct push provider, fixes #534 #535
Add direct push provider, fixes #534 #535
Conversation
Hey @lochiiconnectivity 👋🏻 Thanks for raising this. At the moment the Auth0 Terraform Provider only supports managing Push Notification Providers of type "guardian" and "sns". The "direct" type is missing and support for this is blocked until it gets added within the Go SDK that this provider leverages. I don't have an exact ETA of when we could add support for this within the Go SDK but contributions are more than welcomed there as well if you want to give it a try. |
Go SDK indicates that this is supported - https://github.com/auth0/go-auth0/blob/main/management/guardian.go#L339, this was added in auth0/go-auth0#136 |
Thanks for pointing that out @lochiiconnectivity, and apologies I should've been more precise. Although you can select the provider through the Go SDK using https://github.com/auth0/go-auth0/blob/main/management/guardian.go#L339, you can't configure the setting's for Push Notification that uses a Direct Provider because the endpoints are missing. It's not enough to simply set the selected provider to "direct", in order to update these fields |
See auth0/go-auth0#184 - if this moves forward, I will integrate support for the new SDK methods into this PR |
That's awesome @lochiiconnectivity 🙇🏻 this is highly appreciated! I'll reopen this then and mark it as a draft instead. |
d68e807
to
2f7e607
Compare
Added content to enable the new functionality, but left placeholder references in go.mod and go.sum until the new SDK release, when that happens, will update with the final release version and hash |
a8277ff
to
570e1f6
Compare
Thanks @lochiiconnectivity 👍🏻 , I rebased your PR and pointed go-auth0 to latest main so we're not blocked until we make the release to ensure this PR is in the right place. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
==========================================
- Coverage 84.26% 84.18% -0.08%
==========================================
Files 78 78
Lines 10186 10293 +107
==========================================
+ Hits 8583 8665 +82
- Misses 1295 1317 +22
- Partials 308 311 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
570e1f6
to
cce063c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @lochiiconnectivity 💯 , we cut a release on the Auth0 Go SDK and I rebased this PR along with a few very minor tweaks. Thanks a lot for the contribution!
🔧 Changes
Add support for direct MFA push provider, fixes #534
📚 References
See #534
🔬 Testing
Use direct push provider
📝 Checklist