Add direct push provider, fixes #534

[lochiiconnectivity]

🔧 Changes

Add support for direct MFA push provider, fixes #534

📚 References

See #534

🔬 Testing

Use direct push provider

📝 Checklist

• All new/changed/fixed functionality is covered by tests (or N/A)
• I have added documentation for all new/changed functionality (or N/A)

[sergiught]

Hey @lochiiconnectivity 👋🏻

Thanks for raising this. At the moment the Auth0 Terraform Provider only supports managing Push Notification Providers of type "guardian" and "sns". The "direct" type is missing and support for this is blocked until it gets added within the Go SDK that this provider leverages.

I don't have an exact ETA of when we could add support for this within the Go SDK but contributions are more than welcomed there as well if you want to give it a try.

[lochiiconnectivity]

Go SDK indicates that this is supported - https://github.com/auth0/go-auth0/blob/main/management/guardian.go#L339, this was added in auth0/go-auth0#136

[sergiught]

Thanks for pointing that out @lochiiconnectivity, and apologies I should've been more precise. Although you can select the provider through the Go SDK using https://github.com/auth0/go-auth0/blob/main/management/guardian.go#L339, you can't configure the setting's for Push Notification that uses a Direct Provider because the endpoints are missing.

It's not enough to simply set the selected provider to "direct", in order to update these fields

We need support for the following endpoints:

• https://auth0.com/docs/api/management/v2#!/Guardian/get_apns
• https://auth0.com/docs/api/management/v2#!/Guardian/patch_apns
• https://auth0.com/docs/api/management/v2#!/Guardian/patch_fcm
• https://auth0.com/docs/api/management/v2#!/Guardian/get_fcm

[lochiiconnectivity]

See auth0/go-auth0#184 - if this moves forward, I will integrate support for the new SDK methods into this PR

[sergiught]

That's awesome @lochiiconnectivity 🙇🏻 this is highly appreciated! I'll reopen this then and mark it as a draft instead.

[lochiiconnectivity]

Added content to enable the new functionality, but left placeholder references in go.mod and go.sum until the new SDK release, when that happens, will update with the final release version and hash

[sergiught]

Thanks @lochiiconnectivity 👍🏻 , I rebased your PR and pointed go-auth0 to latest main so we're not blocked until we make the release to ensure this PR is in the right place.

[codecov-commenter]

Codecov Report

Patch coverage: 77.06% and project coverage change: -0.08 ⚠️

Comparison is base (73204bf) 84.26% compared to head (570e1f6) 84.18%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #535      +/-   ##
==========================================
- Coverage   84.26%   84.18%   -0.08%     
==========================================
  Files          78       78              
  Lines       10186    10293     +107     
==========================================
+ Hits         8583     8665      +82     
- Misses       1295     1317      +22     
- Partials      308      311       +3     

Impacted Files	Coverage Δ
internal/auth0/guardian/expand.go	69.17% <38.88%> (-4.49%)	⬇️
internal/auth0/guardian/flatten.go	75.13% <84.21%> (+1.06%)	⬆️
internal/auth0/guardian/resource.go	94.40% <100.00%> (+0.67%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[sergiught]

Awesome work @lochiiconnectivity 💯 , we cut a release on the Auth0 Go SDK and I rebased this PR along with a few very minor tweaks. Thanks a lot for the contribution!