Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFA Push CustomApp should be type 'direct' and not 'guardian' #534

Closed
6 tasks done
lochiiconnectivity opened this issue Mar 15, 2023 · 4 comments · Fixed by #535
Closed
6 tasks done

MFA Push CustomApp should be type 'direct' and not 'guardian' #534

lochiiconnectivity opened this issue Mar 15, 2023 · 4 comments · Fixed by #535
Labels
🌱 feature New feature or request

Comments

@lochiiconnectivity
Copy link
Contributor

Checklist

  • I have looked into the README and have not found a suitable solution or answer.
  • I have looked into the documentation and have not found a suitable solution or answer.
  • I have searched the issues and have not found a suitable solution or answer.
  • I have upgraded to the latest version of this provider and the issue still persists.
  • I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • I agree to the terms within the Auth0 Code of Conduct.

Description

MFA Push CustomApp should be type 'direct' and not 'guardian', if you select custom app in the UI this corresponds to provider 'direct' in the Management API (see https://auth0.com/docs/api/management/v2#!/Guardian/put_selected_provider_0)

Expectation

Guardian MFA "Push" provider should accept 'direct' as a type, in addition to 'guardian' and 'sns'

Reproduction

  1. Set up guardian with push notifications to a customer app in the UI
  2. Specify provider "guardian" in the TF:
  push {
    enabled     = true
    provider    = "guardian"
 }
  1. Run "terraform plan", terraform reports that the provider has changed from "direct" to "guardian"
      ~ push {
          ~ provider = "direct" -> "guardian"

Auth0 Terraform Provider version

0.44.1

Terraform version

1.4.0

@lochiiconnectivity lochiiconnectivity added the 🪲 bug Something isn't working label Mar 15, 2023
lochiiconnectivity pushed a commit to lochiiconnectivity/terraform-provider-auth0 that referenced this issue Mar 15, 2023
@sergiught
Copy link
Contributor

sergiught commented Mar 15, 2023

Hey @lochiiconnectivity 👋🏻

Thanks for raising this. At the moment the Auth0 Terraform Provider only supports managing Push Notification Providers of type "guardian" and "sns". The "direct" type is missing and support for this is blocked until it gets added within the Go SDK that this provider leverages. So this isn't really a bug, but a missing feature that you're requesting.

I don't have an exact ETA of when we could add support for this within the Go SDK but contributions are more than welcomed there as well.

@sergiught sergiught added 🌱 feature New feature or request and removed 🪲 bug Something isn't working labels Mar 15, 2023
@lochiiconnectivity
Copy link
Contributor Author

See #535 (comment)

@lochiiconnectivity
Copy link
Contributor Author

See #535 (comment)

lochiiconnectivity added a commit to lochiiconnectivity/terraform-provider-auth0 that referenced this issue Mar 16, 2023
sergiught pushed a commit to lochiiconnectivity/terraform-provider-auth0 that referenced this issue Mar 17, 2023
sergiught added a commit that referenced this issue Apr 21, 2023
Co-authored-by: Sergiu Ghitea <28300158+sergiught@users.noreply.github.com>
@sergiught sergiught reopened this Apr 21, 2023
@sergiught
Copy link
Contributor

Thanks again @lochiiconnectivity for raising this. It is now available within the latest https://github.com/auth0/terraform-provider-auth0/releases/tag/v0.46.0. Please let us know if you have any issues with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants