Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong z-index on modal error message in manual setup #252

Closed
rolodato opened this issue Oct 19, 2016 · 2 comments
Closed

Wrong z-index on modal error message in manual setup #252

rolodato opened this issue Oct 19, 2016 · 2 comments
Assignees
Milestone

Comments

@rolodato
Copy link
Contributor

Repro steps:

  1. Install the plugin
  2. Choose manual setup
  3. Focus the token field, leave it empty and hit Enter
  4. A modal appears behind the current one, which can't be seen:

image

@glena
Copy link
Contributor

glena commented Oct 19, 2016

Not z-index, it is because hitting enter submits the form which produces it to show again the popup to pick which type of setup you want to use

image

will check, but if you hit continue it should not affect to the entire flow.

@joshcanhelp joshcanhelp added the bug label Mar 8, 2018
@joshcanhelp joshcanhelp added this to the 3.6.0 milestone May 24, 2018
@joshcanhelp joshcanhelp added CH: Fixed and removed bug labels May 24, 2018
@joshcanhelp joshcanhelp self-assigned this May 24, 2018
@joshcanhelp
Copy link
Contributor

Fixed in #468 and merged into dev ... disabled the enter key in that modal.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants