-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling errors #403
Comments
@Floppy - That's not helpful, though I do have it on my list to handle those stop-points better. The function we use, If you would, can you check in with Pagely and see if this would work to skip their error pages? $msg = __( 'There was a problem with your login', 'wp-auth0' );
$title = __( 'Auth0 error', 'wp-auth0' );
wp_die( $msg, $title, array( 'response' => 200 ) ); |
It's very good of you to offer, but thinking about it a bit more, sending a 200 code with an error is a really non-webby thing to do and you shouldn't let me push you into it. I'm sure that sending a 200 would avoid their error trapping, but to me it's not the right thing to do (I'm a bit obsessive about HTTP codes). We're going to move off there soon anyway, so I think we'll just have to live with it until then. The thing I was thinking is to perhaps add an error URL option, which could send the error message in GET parameters to a page that could display them. However, I notice while debugging something else that in many cases, a |
I agree that a 200 code with a server error is not a great idea but this isn't a server error that indicates a network problem, it's a problem with a specific user's login process. The server connected, processed the request, and found an issue. I don't think indicating that with a 500 code is the right thing to do. We used We're working on the next major version of this plugin in the background and improved error handling is high on the list. Thanks! |
Yes, that's true, should be something in the 4xx range probably. |
Our wordpress instance is on Pagely, which irritatingly masks loads of error pages with its own error page, throwing away all the content. When we get OAuth errors, it doesn't show anything useful. Is there any way to tell the plugin to show a specific error page, so that we can customise it?
The text was updated successfully, but these errors were encountered: