Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a configurable toggle that allows Users to state if federated logout should be used #471

Closed
moolbits opened this issue Jun 4, 2018 · 1 comment
Milestone

Comments

@moolbits
Copy link

moolbits commented Jun 4, 2018

There's currently no way for Users to have SSO enabled without then triggering a full federated logout.

The problem is that when 3rd party identity providers are facilitating the connection, like Google and Facebook, the User is redirected back to Google or Facebook respectively, and there is currently no way to change this behavior in the settings for the plugin.

It would be of great value in cases where a federated logout is not a requirement to have a non-federated option, when it comes to leveraging SSO enabled, and Social Connections in particular.

As of right now, according to Enterprise Support, the only way to have SSO enabled without then triggering a full federated logout is to edit the plugin directly:

"...use a modified version of the Wordpress Auth0 plugin where you would remove the federated option from https://github.com/auth0/wp-auth0/blob/9713e6a7cdf4c3446632be5338426dfba102bf3a/lib/WP_Auth0_LoginManager.php#L99 "

This approach is less than ideal, not only because editing Wordpress Plugins directly is bad practice, but also because doing so in this way would supply non-federated logouts for all logout methods, including Username and Password.

Suggesting an enhancement that would expose a configurable toggle that would allow Users to state if a federated logout should be used or not for Social Connections when SSO is enabled. It would be really nice if federated logouts could be toggled non-federated, for each Social Connection individually.

@joshcanhelp joshcanhelp added this to the 3.6.0 milestone Jun 4, 2018
@joshcanhelp
Copy link
Contributor

@moolbits - Thanks so much for the thorough report here! This was an issue identified earlier and is fixed in a release coming out tomorrow (#453). The fix was to just remove federated because it's far more likely that a site owner needs a non-federated logout. I am tracking an issue internally to include a filter to adjust that, if needed.

Let me know if you have any questions or any issues after tomorrow's update!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants