Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally load client ID, secret and domain from environment #480

Closed
Floppy opened this issue Jun 7, 2018 · 4 comments
Closed

Optionally load client ID, secret and domain from environment #480

Floppy opened this issue Jun 7, 2018 · 4 comments
Assignees
Milestone

Comments

@Floppy
Copy link

Floppy commented Jun 7, 2018

We have multiple environments that we keep in sync with database backups cloned between them. Obviously this confused the Auth0 plugin as it doesn't have the right credentials any more.

Loading the credentials from the environment in a 12-factor app style would make this a lot easier. Perhaps if the values are blank in the database they could be loaded from the env? Another issue here is the user migration token, which could perhaps be generated in a more stable fashion so it doesn't need to be stored in the database?

@joshcanhelp
Copy link
Contributor

@Floppy - Thank you for the suggestion on this. We were considering something like this for sensitive data storage like the ones you mentioned. WordPress convention is to define a constant in wp-config.php, rather than a .env file. Would that work for your purposes? Then we don't have to load a separate env-parsing library.

@joshcanhelp
Copy link
Contributor

joshcanhelp commented Jun 15, 2018

Tracking progress in #488

@Floppy
Copy link
Author

Floppy commented Jul 4, 2018

Yeah, it's probably best to stick to the wordpress standard. We can always use an env loader inside our wp-config.php to do the next step.

@joshcanhelp
Copy link
Contributor

Fixed in #509, merged into dev. Release coming soon!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants