Setting titles and option names #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
force-pushed
the
fix-settings-names
branch
from
6b269a4
to
3b00572
Compare
joshcanhelp
changed the title
luisrudge
approved these changes
Apr 4, 2018
Setting names were incorrect, confusing in some cases, and used inconsistent capitalization. Rewrite setting names and adding proper translations. Add opt names to the settings array for more simple HTML output (upcoming PR). Add a filter to add or modify settings array.
joshcanhelp
force-pushed
the
fix-settings-names
branch
from
3b00572
to
736231c
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting names were incorrect, confusing in some cases, and used
inconsistent capitalization.
Rewrite setting names and adding proper translations. Add opt names to
the settings array for more simple HTML output (upcoming PR). Add a
filter to add or modify settings array. Changed Client => Application.