Fix Passwordless handling; update Lock instantiation #434

joshcanhelp · 2018-04-16T16:41:33Z

Main focus here was to update Lock Passwordless to use the combined library and move all instantiation JS to an external file, populated via wpAuth0LockGlobal

Combined JS file to initiate Lock; removed JS from PHP template files
Removing unused template files
README support block, whitespace

Fixes #400, #430

joshcanhelp · 2018-04-16T17:06:02Z

README.md

@@ -27,8 +27,7 @@ We're happy to review and approve new filters and actions that help you integrat
 **Thank you in advance!**


Only line break changes here. Surfaced during a rebase.

joshcanhelp · 2018-04-16T17:14:09Z

templates/auth0-login-form-lock10.php

@@ -1,98 +0,0 @@
-<?php


Combined with templates/auth0-login-form.php

joshcanhelp · 2018-04-16T17:14:33Z

templates/auth0-login-form.php

@@ -1,212 +1,27 @@
 <?php


Modified to handle standard and Passwordless

joshcanhelp · 2018-04-16T17:15:53Z

templates/auth0-login-form.php

-    var callback = null;
-
-
-    <?php if ( $lock_options->get_auth0_implicit_workflow() ) { ?>


All this moved into a separate file in #426

For the new time, please try to keep the "refactor->move" actions in the same PR for diff tracking.

joshcanhelp · 2018-04-16T17:17:12Z

templates/error-msg.php

@@ -1,34 +0,0 @@
-<?php if ( isset( $_GET['message'] ) ): ?>


Checked with @glena, this is likely not used anymore. No references in the plugin anymore and duplicates the wp_die() catches during login.

this is likely not used anymore

Are you tracking usage somehow? can this be safely removed or would it be considered a breaking change in your opinion?

I believe it can be safely removed, yes. No other references to this and this functionality (minus the URL param) is part of the main login flow. There's nothing in the plugin that uses this functionality and I've never seen it during any testing thus far.

joshcanhelp · 2018-04-16T17:18:58Z

templates/login-form.php

+      )
+    );
+
+    $login_tpl = apply_filters( 'auth0_login_form_tpl', 'auth0-login-form.php', $lock_options, $canShowLegacyLogin );


Added a note for myself to document this hook when released

joshcanhelp · 2018-04-16T17:19:12Z

lib/WP_Auth0_Lock10_Options.php

-        "params" => array("state" => $state ),
+        "params" => array(
+          "state" => $this->get_state_obj( $redirect_to ),
+          "scope" => apply_filters( 'auth0_auth_param_scopes', $this->_scopes ),


Added a note for myself to document this hook when released

joshcanhelp · 2018-04-16T17:20:20Z

readme.txt

@@ -128,6 +128,19 @@ All is not lost!
 * If you have questions about how to use Auth0 or the plugin, please [post on our community site](https://community.auth0.com/) or create a [support forum request here](https://wordpress.org/support/plugin/auth0).
 * You can also see additional documentation and answers on our [support site](https://support.auth0.com/). Customers on a paid Auth0 plan can [submit a trouble ticket](https://support.auth0.com/tickets) for a fast response.

+= My question is not covered here; what do I do? =


Surfaced during a rebase.

joshcanhelp · 2018-04-16T17:22:14Z

templates/auth0-login-form.php

-
-    if (lock.on) {
-        lock.on('ready', function(){
-            if ( lock.options['$client'].subscription === 'free' ) {


Was not working properly in all cases. Made a note to address this in a later release.

AFAIK we don't rely on this client info value since it's easy to change on the fly (@luisrudge). If that's the case then Josh can you do the same?

correct. we don't use that anywhere.

Documentation for the plugin resides in mulitple places - auth0.com docs, wp.org readme, GitHub readme - and this commit is part of an on- going effort to consolidate and clarify. This commit removes the installation instructions on wp.org, pointing to the docs site instead. It also updates the screenshots and adds information about support to the FAQs. This commit also clearly points the GitHub readme to docs in a few cases and updates the dev instructions.

State generation, specifically cookie storage, needs to happen before any output. The previous arch was ok for login page generation but failed with a "headers already set" error if used in the shortcode. This addresses the issue by storing state earlier and getting the value later.

Passwordless (PWL) was not working with new tenants and used the old, separate PWL JS library. This commit updates the Lock library used to 11.5, moves and re-writes the JS used to show Lock, loads required JS in one place for widget + shortcode + wp-login, and revises state handling to work better for the shortcode and widget.

lbalmaceda

Mostly text format issues

lbalmaceda · 2018-04-17T18:09:02Z

readme.txt

+
+All is not lost!
+
+* If you're setting up the plugin for the first time or having issues after an upgrade, please review the [configuration


new line after [configuration

lbalmaceda · 2018-04-17T18:09:40Z

readme.txt

+
+* If you're setting up the plugin for the first time or having issues after an upgrade, please review the [configuration
+ page at auth0.com/docs](https://auth0.com/docs/cms/wordpress/configuration)
+* If you found a bug in the plugin code [submit an issue](https://github.com/auth0/wp-auth0/issues) or [create a pull


new line after pull

lbalmaceda · 2018-04-17T18:10:08Z

readme.txt

+* If you're setting up the plugin for the first time or having issues after an upgrade, please review the [configuration
+ page at auth0.com/docs](https://auth0.com/docs/cms/wordpress/configuration)
+* If you found a bug in the plugin code [submit an issue](https://github.com/auth0/wp-auth0/issues) or [create a pull
+request](https://github.com/auth0/wp-auth0/pulls) on [GitHub](https://github.com/auth0/wp-auth0/).


IMO the last github link is overkill. It's already on the pull requests one

lbalmaceda · 2018-04-17T18:11:20Z

readme.txt

+ page at auth0.com/docs](https://auth0.com/docs/cms/wordpress/configuration)
+* If you found a bug in the plugin code [submit an issue](https://github.com/auth0/wp-auth0/issues) or [create a pull
+request](https://github.com/auth0/wp-auth0/pulls) on [GitHub](https://github.com/auth0/wp-auth0/).
+* If you have questions about how to use Auth0 or the plugin, please [post on our community site](https://community


new line after community

lbalmaceda · 2018-04-17T18:11:34Z

readme.txt

+request](https://github.com/auth0/wp-auth0/pulls) on [GitHub](https://github.com/auth0/wp-auth0/).
+* If you have questions about how to use Auth0 or the plugin, please [post on our community site](https://community
+.auth0.com/) or create a [support forum request here](https://wordpress.org/support/plugin/auth0).
+* You can also see additional documentation and answers on our [support site](https://support.auth0.com/). Customers on


new line after on

lbalmaceda · 2018-04-17T18:13:21Z

templates/auth0-login-form.php

-    var callback = null;
-
-
-    <?php if ( $lock_options->get_auth0_implicit_workflow() ) { ?>


For the new time, please try to keep the "refactor->move" actions in the same PR for diff tracking.

lbalmaceda · 2018-04-17T18:14:36Z

templates/auth0-login-form.php

-
-    if (lock.on) {
-        lock.on('ready', function(){
-            if ( lock.options['$client'].subscription === 'free' ) {


AFAIK we don't rely on this client info value since it's easy to change on the fly (@luisrudge). If that's the case then Josh can you do the same?

lbalmaceda · 2018-04-17T18:15:57Z

templates/error-msg.php

@@ -1,34 +0,0 @@
-<?php if ( isset( $_GET['message'] ) ): ?>


this is likely not used anymore

Are you tracking usage somehow? can this be safely removed or would it be considered a breaking change in your opinion?

…rm id constant

lbalmaceda

LG

joshcanhelp added the work in progress label Apr 16, 2018

joshcanhelp commented Apr 16, 2018

View reviewed changes

templates/auth0-login-form-lock10.php

@@ -1,98 +0,0 @@

<?php

Copy link

Contributor Author

joshcanhelp Apr 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combined with templates/auth0-login-form.php

joshcanhelp commented Apr 16, 2018

View reviewed changes

templates/auth0-login-form.php

@@ -1,212 +1,27 @@

<?php

Copy link

Contributor Author

joshcanhelp Apr 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified to handle standard and Passwordless

joshcanhelp commented Apr 16, 2018

View reviewed changes

joshcanhelp force-pushed the fix-passwordless branch from e3046c6 to 4a4261e Compare April 16, 2018 20:23

joshcanhelp added CH: Fixed and removed work in progress labels Apr 16, 2018

joshcanhelp added this to the v3-Next milestone Apr 16, 2018

joshcanhelp force-pushed the fix-passwordless branch from 4a4261e to 87aad83 Compare April 16, 2018 20:36

joshcanhelp added 5 commits April 17, 2018 08:04

Clean up and streamline repo README

fc9621e

minor formatting changes requests on PR review

a57f7fd

joshcanhelp force-pushed the fix-passwordless branch from 87aad83 to 313a1bf Compare April 17, 2018 15:04

lbalmaceda reviewed Apr 17, 2018

View reviewed changes

Combining Lock init process; removing unused templates; Lock login fo…

95e1cea

…rm id constant

joshcanhelp force-pushed the fix-passwordless branch from 313a1bf to 95e1cea Compare April 17, 2018 22:36

lbalmaceda approved these changes Apr 19, 2018

View reviewed changes

joshcanhelp merged commit b885c81 into dev Apr 19, 2018

joshcanhelp deleted the fix-passwordless branch April 19, 2018 14:23

joshcanhelp removed the Ready for Review label Apr 19, 2018

joshcanhelp mentioned this pull request May 3, 2018

Widget URL changes don't save when you are using passwordless #430

Closed

This was referenced May 3, 2018

CORS errors #400

Closed

Normalize use of shortcode and widget #260

Closed

joshcanhelp mentioned this pull request Jun 5, 2018

Release 3.6.0 #475

Merged

github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Passwordless handling; update Lock instantiation #434

Fix Passwordless handling; update Lock instantiation #434

joshcanhelp commented Apr 16, 2018

joshcanhelp Apr 16, 2018 •

edited

Loading

joshcanhelp Apr 16, 2018

joshcanhelp Apr 16, 2018

joshcanhelp Apr 16, 2018

lbalmaceda Apr 17, 2018

joshcanhelp Apr 16, 2018

lbalmaceda Apr 17, 2018

joshcanhelp Apr 17, 2018

joshcanhelp Apr 16, 2018

joshcanhelp Apr 16, 2018

joshcanhelp Apr 16, 2018

joshcanhelp Apr 16, 2018

lbalmaceda Apr 17, 2018

luisrudge Apr 17, 2018

joshcanhelp Apr 17, 2018

lbalmaceda left a comment

lbalmaceda Apr 17, 2018

lbalmaceda Apr 17, 2018

lbalmaceda Apr 17, 2018

lbalmaceda Apr 17, 2018

lbalmaceda Apr 17, 2018

lbalmaceda Apr 17, 2018

lbalmaceda Apr 17, 2018

lbalmaceda Apr 17, 2018

lbalmaceda left a comment

		@@ -27,8 +27,7 @@ We're happy to review and approve new filters and actions that help you integrat
		Thank you in advance!

		var callback = null;


		<?php if ( $lock_options->get_auth0_implicit_workflow() ) { ?>


		All is not lost!

		* If you're setting up the plugin for the first time or having issues after an upgrade, please review the [configuration

Fix Passwordless handling; update Lock instantiation #434

Fix Passwordless handling; update Lock instantiation #434

Conversation

joshcanhelp commented Apr 16, 2018

joshcanhelp Apr 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lbalmaceda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lbalmaceda left a comment

Choose a reason for hiding this comment

joshcanhelp Apr 16, 2018 •

edited

Loading