Add code quality tools and contrib instructions #498
Conversation
| @@ -3,7 +3,7 @@ | |||
| Login by Auth0 | |||
| ==== | |||
|
|
|||
| Single Sign On for Enterprises + Social Login + User/Passwords. For all your WordPress instances. Powered by Auth0. | |||
| Single Sign On for Enterprises + Social Login + User/Passwords + Passwordless. For all your WordPress instances. Powered by Auth0. | |||
There was a problem hiding this comment.
Might be nicer as a bullet point list vs +
There was a problem hiding this comment.
I agree since this is getting bigger, but he's already using a bulleted list below this paragraph.
There was a problem hiding this comment.
How about:
"SSO, Social Login, Username & Passwords, Passwordless, and more."
| @@ -53,20 +56,22 @@ git clone https://github.com/joshcanhelp/auth0-wp-test.git ./wp-content/themes/a | |||
| # Optional, clones the testing theme to assist with development | |||
| ``` | |||
|
|
|||
There was a problem hiding this comment.
I feel this should be in the repo as an additional file, it seems strange for us to link to your own personal gist, appreciate there probably wasn't an accessible Auth0 one.
There was a problem hiding this comment.
I don't mind as long as the content is kept up to date.
There was a problem hiding this comment.
I totally agree. I was a little apprehensive to do it on my own one. It a lot of code to review to put out there, TBH. Would be nice as part of the plugin, though, as you could symlink from the themes folder (or copy) and use it for testing. I can add in another PR?
|
will assume all your rules work 😄 |
|
@cocojoe - They work but the plugin has a long way to go before passing all those sniffs. One PR at a time! |
No description provided.