Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove signup disabling #501

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Remove signup disabling #501

merged 1 commit into from
Jul 19, 2018

Conversation

joshcanhelp
Copy link
Contributor

The WordPress plugin is both disabling signups on the Connection (via API) and social signups (via Rules) based on the WordPress registration setting. This is not good for anyone with multiple Applications using the same connections. Need to remove this functionality and deprecate the functions involved.

  • Remove $this->check_signup_status(); call on initialize
  • TODOs for deprecation

@joshcanhelp joshcanhelp added this to the v3-Next milestone Jul 18, 2018
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshcanhelp joshcanhelp merged commit 16731a9 into dev Jul 19, 2018
@joshcanhelp joshcanhelp deleted the remove-signup-disabling branch July 19, 2018 16:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants