Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation ability #507

Merged
merged 1 commit into from
Jul 27, 2018
Merged

Add translation ability #507

merged 1 commit into from
Jul 27, 2018

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Jul 24, 2018

  • Add translation to strings throughout the plugin
  • Add text-domain loading
  • Add main POT file and English translation files (see below)

Note for reviewer(s): The PO and POT files (~95% of added lines in this PR) are all generated from translatable strings in the plugin. Much of this language came from the settings page, which was recently re-written and reviewed. Reviewing these is probably superfluous.

@@ -1,23 +0,0 @@
<form method="post" class="wp-form-signin" action="">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Template not used

@joshcanhelp joshcanhelp force-pushed the add-translation-ability branch 3 times, most recently from 0cc8397 to c8f86f6 Compare July 26, 2018 19:05
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Nice improvement for translations

@joshcanhelp joshcanhelp merged commit 9f9127e into dev Jul 27, 2018
@joshcanhelp joshcanhelp deleted the add-translation-ability branch July 27, 2018 14:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants