Do not store the API token on install #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Mar 25, 2019
| @@ -175,6 +175,7 @@ public static function get_client_token() { | |||
| } | |||
There was a problem hiding this comment.
Comments only in this file.
damieng
approved these changes
Mar 25, 2019
|
Do we need to clean this token up on existing installs or did it never ship? |
|
@damieng - When the field is removed, I'll delete the stored one as well. For 99%+ installs, the token is already expired. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
References
Continues the work from #637 and #632 to remove the App Token field (use a Client Credentials grant for Management API work and store in a expiring transient).
Testing
This can be tested manually by installing the plugin from scratch on a new site. Expect no changes to behavior.
Checklist