-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to generate a new migration token #640
Conversation
8625bda
to
8d9d3ad
Compare
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
============================================
+ Coverage 40.02% 40.72% +0.69%
- Complexity 1235 1239 +4
============================================
Files 51 51
Lines 3765 3784 +19
============================================
+ Hits 1507 1541 +34
+ Misses 2258 2243 -15
Continue to review full report at Codecov.
|
}; | ||
$.post(wpa0.ajax_url, postData, function() { | ||
$( '#auth0_migration_token' ).text(wpa0.refresh_prompt); | ||
$rotateTokenButton.remove(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's kind of odd for buttons to disappear on UIs. Is there a problem with leaving it there in case something went wrong? Or do they really need to refresh the page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function is success-only and doesn't need any data, just a 200 code. Putting the new token in the code block would be nice but would require sending the new token unnecessarily. I can't refresh the page for the user in case there are other changes that have not been saved.
Changes
Adds a button to generate a new migration token for user migration setups.
References
Testing
Failed tests for new field and functionality
Manual Steps:
wp-config.php
:AUTH0_ENV_MIGRATION_TOKEN
definition added aboveChecklist