Add new options for WordPress Login Enabled #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
force-pushed
the
add-more-wle-options
branch
from
51d7a90
to
5cd6418
Compare
joshcanhelp
commented
Mar 26, 2019
| @@ -682,9 +676,6 @@ public static function get_authorize_params( $connection = null, $redirect_to = | |||
| $params['connection'] = $connection; | |||
| } | |||
|
|
|||
| // Get the telemetry header. | |||
There was a problem hiding this comment.
Unused from previous PR.
joshcanhelp
force-pushed
the
add-more-wle-options
branch
from
5cd6418
to
269f818
Compare
joshcanhelp
commented
Mar 26, 2019
|
|
||
| if ( isset( $_GET['wle'] ) ) { | ||
| if ( $this->options->can_show_wp_login_form() ) { |
There was a problem hiding this comment.
Relevant change here.
joshcanhelp
commented
Mar 26, 2019
| @@ -310,10 +369,6 @@ public function basic_validation( $old_options, $input ) { | |||
| $input['client_id'] = sanitize_text_field( $input['client_id'] ); | |||
| $input['cache_expiration'] = absint( $input['cache_expiration'] ); | |||
|
|
|||
| $input['wordpress_login_enabled'] = ( isset( $input['wordpress_login_enabled'] ) | |||
There was a problem hiding this comment.
Moved to wle_validation
joshcanhelp
commented
Mar 26, 2019
| @@ -373,6 +373,7 @@ public function basic_validation( $old_options, $input ) { | |||
| // Turn SLO off if SSO is off. | |||
| $input['singlelogout'] = empty( $input['singlelogout'] ) || empty( $input['sso'] ) ? 0 : 1; | |||
|
|
|||
| $input['auto_login'] = empty( $input['auto_login'] ) ? 0 : 1; | |||
There was a problem hiding this comment.
Missing settings validation causing ULP setting to malfunction
joshcanhelp
commented
Mar 26, 2019
| @@ -118,12 +118,6 @@ public function login_auto() { | |||
| return false; | |||
| } | |||
|
|
|||
| // Do not redirect Auth0 login processing. | |||
| // TODO: This should be removed as this page is no longer used for callbacks. | |||
| if ( null !== $this->query_vars( 'auth0' ) ) { | |||
There was a problem hiding this comment.
Callback is not actually processed on this page so this just closes a hole.
Reason for removed tests in tests/testLoginManager.php.
joshcanhelp
commented
Mar 26, 2019
| /** | ||
| * Test that the ULP redirect does not happen if wp-login.php is used as a callback. | ||
| */ | ||
| public function testThatUlpRedirectIsSkippedForCallback() { |
There was a problem hiding this comment.
Explained above.
joshcanhelp
changed the title
joshcanhelp
force-pushed
the
add-more-wle-options
branch
from
269f818
to
b0f1e39
Compare
|
I'm finding this UI a little confusing. Might it be better to put the descriptions next to the various checkboxes so you can see all the details at a glance? wle enabled, wle present etc. is hard to understand at a glance. |
|
@damieng - I think you're right. I'll take another pass at this, thank you. |
joshcanhelp
force-pushed
the
add-more-wle-options
branch
from
e52ec19
to
a0b01a8
Compare
damieng
previously approved these changes
Mar 29, 2019
joshcanhelp
force-pushed
the
add-more-wle-options
branch
from
a0b01a8
to
f86bdde
Compare
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
============================================
+ Coverage 40.71% 41.85% +1.13%
- Complexity 1231 1244 +13
============================================
Files 51 51
Lines 3753 3799 +46
============================================
+ Hits 1528 1590 +62
+ Misses 2225 2209 -16
Continue to review full report at Codecov.
|
damieng
previously approved these changes
Mar 29, 2019
joshcanhelp
force-pushed
the
add-more-wle-options
branch
from
f86bdde
to
46d00a4
Compare
damieng
approved these changes
Mar 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
UI change:
References
Testing
Checklist