Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Delete MFA control on user profile; add link to user in dashboard #644

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Mar 26, 2019

Changes

The Delete MFA control on the user profile was not playing nicely with how MFA is deleted. Since we have not had any reports about it, this PR removes the control and adds a link to the user in the Auth0 dashboard where MFA changes can be made directly.

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp marked this pull request as ready for review March 27, 2019 00:04
@joshcanhelp joshcanhelp added this to the 3.10.0 milestone Mar 27, 2019
@codecov-io
Copy link

Codecov Report

Merging #644 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #644      +/-   ##
============================================
+ Coverage     39.93%   39.99%   +0.06%     
  Complexity     1227     1227              
============================================
  Files            51       51              
  Lines          3734     3733       -1     
============================================
+ Hits           1491     1493       +2     
+ Misses         2243     2240       -3
Impacted Files Coverage Δ Complexity Δ
lib/WP_Auth0_EditProfile.php 33.33% <ø> (ø) 2 <0> (ø) ⬇️
lib/api/WP_Auth0_Api_Delete_User_Mfa.php 100% <ø> (ø) 8 <0> (ø) ⬇️
lib/profile/WP_Auth0_Profile_Delete_Mfa.php 100% <ø> (ø) 12 <0> (ø) ⬇️
WP_Auth0.php 23.14% <ø> (+0.29%) 62 <0> (ø) ⬇️
lib/profile/WP_Auth0_Profile_Delete_Data.php 100% <100%> (ø) 8 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 843feb5...85d22ca. Read the comment docs.

Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshcanhelp joshcanhelp merged commit 3d8da5a into master Mar 29, 2019
@joshcanhelp joshcanhelp deleted the remove-mfa-controls-add-link branch March 29, 2019 16:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants