Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate WP_Auth0_Lock10_Options class #654

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

joshcanhelp
Copy link
Contributor

Changes

This PR deprecates the following methods:

  • WP_Auth0_Lock10_Options::get_sso() - No longer used.
  • WP_Auth0_Lock10_Options::get_client_id() - No longer used.

@joshcanhelp joshcanhelp added this to the 3.10.0 milestone Mar 30, 2019
@codecov-io
Copy link

Codecov Report

Merging #654 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #654      +/-   ##
============================================
+ Coverage     42.12%   42.17%   +0.04%     
+ Complexity     1238     1236       -2     
============================================
  Files            51       51              
  Lines          3779     3775       -4     
============================================
  Hits           1592     1592              
+ Misses         2187     2183       -4
Impacted Files Coverage Δ Complexity Δ
lib/WP_Auth0_Lock10_Options.php 73.14% <ø> (+2.61%) 59 <0> (-2) ⬇️
lib/WP_Auth0_Routes.php 86.61% <ø> (ø) 55 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cab340...81571d9. Read the comment docs.

@joshcanhelp joshcanhelp merged commit 163c9a6 into master Apr 1, 2019
@joshcanhelp joshcanhelp deleted the deprecations-for-lock10-options branch April 1, 2019 15:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants