Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate WP_Auth0_Api_Operations methods #656

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

joshcanhelp
Copy link
Contributor

Changes

This PR deprecates the following methods:

  • WP_Auth0_Api_Operations:: update_wordpress_connection() - No longer used.
  • WP_Auth0_Api_Operations:: toggle_rule() - No longer used.

Added a few more TODO comments and @codeCoverageIgnore annotations

@joshcanhelp joshcanhelp added this to the 3.10.0 milestone Mar 30, 2019
@codecov-io
Copy link

codecov-io commented Mar 30, 2019

Codecov Report

Merging #656 into master will increase coverage by 0.97%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #656      +/-   ##
============================================
+ Coverage     42.59%   43.57%   +0.97%     
+ Complexity     1221     1185      -36     
============================================
  Files            51       50       -1     
  Lines          3742     3658      -84     
============================================
  Hits           1594     1594              
+ Misses         2148     2064      -84
Impacted Files Coverage Δ Complexity Δ
lib/WP_Auth0_DBManager.php 46.66% <ø> (+9.16%) 60 <0> (-9) ⬇️
lib/WP_Auth0_EditProfile.php 33.33% <ø> (ø) 2 <0> (ø) ⬇️
lib/WP_Auth0_Export_Users.php 0% <ø> (ø) 18 <0> (ø) ⬇️
lib/WP_Auth0_Email_Verification.php 100% <ø> (ø) 4 <0> (ø) ⬇️
lib/WP_Auth0_Import_Settings.php 0% <ø> (ø) 26 <0> (ø) ⬇️
lib/WP_Auth0_ErrorLog.php 68.42% <ø> (ø) 12 <0> (ø) ⬇️
lib/WP_Auth0_Api_Operations.php 93.93% <ø> (+21.84%) 6 <0> (-6) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 163c9a6...4940e05. Read the comment docs.

damieng
damieng previously approved these changes Apr 1, 2019
@joshcanhelp joshcanhelp merged commit 1b34da8 into master Apr 1, 2019
@joshcanhelp joshcanhelp deleted the deprecations-for-api-operations branch April 1, 2019 16:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants