Deprecate methods that control field rendering and validation #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #659 +/- ##
============================================
+ Coverage 42.12% 42.42% +0.29%
+ Complexity 1238 1235 -3
============================================
Files 51 51
Lines 3779 3755 -24
============================================
+ Hits 1592 1593 +1
+ Misses 2187 2162 -25
Continue to review full report at Codecov.
|
damieng
approved these changes
Apr 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR deprecates the following methods:
WP_Auth0_Admin_Advanced::render_link_auth0_users()- Setting no longer used, field will be removed in the next major.WP_Auth0_Admin_Advanced::render_jwt_auth_integration()- Integration is deprecated (Deprecate WP JWT Auth plugin configuration #636).WP_Auth0_Admin_Advanced::link_accounts_validation()- No longer used.WP_Auth0_Admin_Appearance::render_custom_css()- Setting is deprecated and will be removed in the next major. See this docs page for how to use external stylesheets.WP_Auth0_Admin_Appearance::render_custom_js()- Setting is deprecated and will be removed in the next major. See this docs page for how to use external JS.WP_Auth0_Admin_Basic::render_auth0_app_token()- Setting is no longer used.WP_Auth0_Admin_Features::render_password_policy()- Setting is no longer used.WP_Auth0_Admin_Features::render_fullcontact()- Setting is no longer used.WP_Auth0_Admin_Features::render_fullcontact_apikey()- Setting is no longer used.WP_Auth0_Admin_Features::render_geo()- Setting is no longer used.WP_Auth0_Admin_Features::render_income()- Setting is no longer used.WP_Auth0_Admin_Features::sso_validation()- Validation is no longer needed.WP_Auth0_Admin_Features::security_validation()- Validation is no longer needed.WP_Auth0_Admin_Features::fullcontact_validation()- Validation is no longer needed.WP_Auth0_Admin_Features::mfa_validation()- Validation is no longer needed.WP_Auth0_Admin_Features::georule_validation()- Validation is no longer needed.WP_Auth0_Admin_Features::incomerule_validation()- Validation is no longer needed.WP_Auth0_Admin_Generic::rule_validation()- Validation is no longer needed.