Deprecations for init functions calling add_action or add_filter #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Apr 1, 2019
| $this->basename = plugin_basename( __FILE__ ); | ||
|
|
||
| $ip_checker = new WP_Auth0_Ip_Check(); | ||
| $ip_checker->init(); |
There was a problem hiding this comment.
Setting was already removed so this call was doing noting.
joshcanhelp
commented
Apr 1, 2019
| @@ -119,10 +120,6 @@ public function init() { | |||
|
|
|||
| add_filter( 'plugin_action_links_' . $this->basename, array( $this, 'wp_add_plugin_settings_link' ) ); | |||
|
|
|||
| if ( isset( $_GET['message'] ) ) { | |||
There was a problem hiding this comment.
Very old functionality, not used.
damieng
approved these changes
Apr 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Deprecates
init()methods that calladd_actionoradd_filter. These will be moved to global functions in the next major release to allow un-hooking when needed.See "Files Changed" tab for methods.