Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Auth0 IPs; do not save duplicate or whitelisted IPs #700

Merged
merged 1 commit into from Jul 29, 2019

Conversation

@joshcanhelp
Copy link
Member

commented Jul 16, 2019

Changes

  • Add new Auth0 incoming IP addresses to fix migration route filters
  • Fix IP address validation to exclude duplicate, empty values, and IPs already whitelisted

References

Current Auth0 IP address list

Testing

  • This change adds unit test coverage
  • This change has been tested on WP 5.2.2

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed
@joshcanhelp joshcanhelp added this to the 3.11.1 milestone Jul 16, 2019
@joshcanhelp joshcanhelp added the small label Jul 29, 2019
@joshcanhelp joshcanhelp requested a review from Jul 29, 2019
@joshcanhelp joshcanhelp force-pushed the add-new-auth0-ips branch from 5c021f2 to 92172d3 Jul 29, 2019
@joshcanhelp joshcanhelp merged commit 3a8a68f into wordpress-org-plugin Jul 29, 2019
6 checks passed
6 checks passed
ci/circleci: php_5 Your tests passed on CircleCI!
Details
ci/circleci: php_7 Your tests passed on CircleCI!
Details
ci/circleci: snyk Your tests passed on CircleCI!
Details
codecov/changes Unable to determine changes, no report found at pull request base.
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 54.03% (+0.76%) compared to 0f3f2f1
Details
@joshcanhelp joshcanhelp deleted the add-new-auth0-ips branch Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.