Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Auth0 IPs; do not save duplicate or whitelisted IPs #700

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Add new Auth0 IPs; do not save duplicate or whitelisted IPs #700

merged 1 commit into from
Jul 29, 2019

Conversation

joshcanhelp
Copy link
Contributor

Changes

  • Add new Auth0 incoming IP addresses to fix migration route filters
  • Fix IP address validation to exclude duplicate, empty values, and IPs already whitelisted

References

Current Auth0 IP address list

Testing

  • This change adds unit test coverage
  • This change has been tested on WP 5.2.2

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp added this to the 3.11.1 milestone Jul 16, 2019
@joshcanhelp joshcanhelp requested a review from a team July 29, 2019 21:42
@joshcanhelp joshcanhelp merged commit 3a8a68f into wordpress-org-plugin Jul 29, 2019
@joshcanhelp joshcanhelp deleted the add-new-auth0-ips branch July 29, 2019 23:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @damieng