Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dashboard widgets #713

Merged
merged 2 commits into from
Aug 12, 2019
Merged

Remove dashboard widgets #713

merged 2 commits into from
Aug 12, 2019

Conversation

joshcanhelp
Copy link
Contributor

Changes

This is a potential (though unlikely) breaking change for developers!

Removing deprecated classes and their associated static assets:

  • Remove WP_Auth0_Admin_Dashboard
  • Remove WP_Auth0_Dashboard_Plugins_Age
  • Remove WP_Auth0_Dashboard_Plugins_Gender
  • Remove WP_Auth0_Dashboard_Plugins_Generic
  • Remove WP_Auth0_Dashboard_Plugins_IdP
  • Remove WP_Auth0_Dashboard_Plugins_Income
  • Remove WP_Auth0_Dashboard_Plugins_Location
  • Remove WP_Auth0_Dashboard_Plugins_Signups
  • Remove WP_Auth0_Dashboard_Widgets

Note to reviewers: As usual, POT, PO, and MO files can be ignored, just removing now-unused translation strings.

@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Aug 9, 2019
@joshcanhelp joshcanhelp requested a review from a team August 9, 2019 20:27
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks misleading from a reviewer perspective saying that this PR "contains breaking changes". I understand a major would probably include them anyway, it's just that I wouldn't tag these as breaking. But that's up to you and how you plan to construct the changelog contents 👍

@joshcanhelp joshcanhelp merged commit 1293e13 into master Aug 12, 2019
@joshcanhelp joshcanhelp deleted the remove-dashboard-widgets branch August 12, 2019 16:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants