Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JWT auth plugin integration #715

Merged
merged 2 commits into from
Aug 15, 2019
Merged

Remove JWT auth plugin integration #715

merged 2 commits into from
Aug 15, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Aug 12, 2019

Changes

This is a potential breaking change for developers!

  • Remove WP_Auth0_Configure_JWTAUTH class
  • Remove public WP_Auth0_UsersRepo::init() method
  • Remove public WP_Auth0_UsersRepo::getUser() method
  • Remove public WP_Auth0_UsersRepo::tokenHasRequiredScopes() method
  • Remove public WP_Auth0_Admin_Advanced::render_jwt_auth_integration() method and associated validation
  • Change WP_Auth0_Settings_Section constructor to remove WP_Auth0_Configure_JWTAUTH argument

Note to reviewers: As usual, POT, PO, and MO files can be ignored, just removing now-unused translation strings.

Testing

  • This change adds unit test coverage
  • This change has been tested on WP 5.2.2

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp requested a review from a team August 12, 2019 22:19
@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Aug 12, 2019
@joshcanhelp joshcanhelp marked this pull request as ready for review August 12, 2019 22:24
@joshcanhelp joshcanhelp merged commit fd6e873 into master Aug 15, 2019
@joshcanhelp joshcanhelp deleted the remove-jwt-auth branch August 15, 2019 20:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants