Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum PHP to 7.0 and WP to 4.9 #732

Merged
merged 3 commits into from
Nov 22, 2019
Merged

Update minimum PHP to 7.0 and WP to 4.9 #732

merged 3 commits into from
Nov 22, 2019

Conversation

joshcanhelp
Copy link
Contributor

Changes

Update minimum PHP version to 7.0

Testing

  • This change has been tested on WP version 5.2.2

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp requested a review from a team November 22, 2019 01:05
@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Nov 22, 2019
@joshcanhelp joshcanhelp removed the request for review from a team November 22, 2019 01:09
@joshcanhelp joshcanhelp changed the title Update minimum PHP to 7.0 and WP to 4.9; remove PHP 5 nonce function Update minimum PHP to 7.0 and WP to 4.9 Nov 22, 2019
@joshcanhelp
Copy link
Contributor Author

This change did not introduce the CI failure here:

https://circleci.com/gh/auth0/wp-auth0/1649
https://circleci.com/gh/auth0/wp-auth0/1650

Working on it now.

@joshcanhelp
Copy link
Contributor Author

Looks like the SVN servers are rate limited now:

https://wordpress.org/support/topic/too-many-requests-when-trying-to-checkout-plugin/

In CI:

circleci@863f2bf05453:/tmp/wordpress-tests-lib/data$ svn up
Updating '.':

Fetching external item into 'plugins/wordpress-importer':
svn: warning: W175002: Unexpected HTTP status 429 'Too Many Requests' on '/!svn/rvr/2199044/wordpress-importer/trunk'

At revision 46758.
svn: E205011: Failure occurred processing one or more externals definitions

@joshcanhelp joshcanhelp requested a review from a team November 22, 2019 18:57
@joshcanhelp
Copy link
Contributor Author

Ready to go! Outstanding php_5 check will not complete as that's been removed from CI in this PR.

lbalmaceda
lbalmaceda approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the Readme.md file, should you also mention the requirements in there?

@joshcanhelp
Copy link
Contributor Author

@lbalmaceda - Not a bad idea. I'll evaluate how to do that when I put together the migration guide 👍

@joshcanhelp joshcanhelp merged commit ba3b1c7 into master Nov 22, 2019
@joshcanhelp joshcanhelp deleted the update-to-php-7 branch November 22, 2019 20:17
This was referenced Jan 13, 2020
Merged
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @lbalmaceda