Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated from WP_Auth0_DBManager and move init to function #746

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Dec 6, 2019

Changes

  • Remove upgrade process for plugin versions < 3.1.6 (no tenants reporting this version)
  • Move WP_Auth0_DBManager::init() functionality to wp_auth0_db_check_update()
  • Remove WP_Auth0_DBManager::init()
  • Remove WP_Auth0_DBManager::check_update()
  • Remove WP_Auth0_DBManager::notice_failed_client_grant()
  • Remove WP_Auth0_DBManager::notice_successful_client_grant()
  • Remove WP_Auth0_DBManager::notice_successful_grant_types()
  • Remove WP_Auth0_DBManager::migrate_users_data()

Testing

  • This change has been tested on WP 5.3

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Dec 6, 2019
@joshcanhelp joshcanhelp marked this pull request as ready for review December 6, 2019 18:49
@joshcanhelp joshcanhelp requested a review from a team December 6, 2019 18:49
* Startup
*/

function wp_auth0_db_check_update() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this change be documented on the init() function or somewhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

init() was removed

@joshcanhelp joshcanhelp requested a review from a team December 9, 2019 18:54
@joshcanhelp joshcanhelp merged commit 9caa432 into master Dec 9, 2019
@joshcanhelp joshcanhelp deleted the remove-deprecated-from-dbmanager branch December 9, 2019 20:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants