Remove deprecated from email verification #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
force-pushed
the
remove-deprecated-from-email-verification
branch
from
398a2a1
to
1b5e260
Compare
joshcanhelp
commented
Dec 13, 2019
| * | ||
| * @codeCoverageIgnore - Tested in TestEmailVerification::testResendVerificationEmail() | ||
| */ | ||
| function wp_auth0_ajax_resend_verification_email() { |
There was a problem hiding this comment.
Moved here from wp_auth0_ajax_resend_verification_email() below (same function) and merged functionality from WP_Auth0_Email_Verification::resend_verification_email()
joshcanhelp
commented
Dec 13, 2019
| * @runInSeparateProcess | ||
| */ | ||
| public function testResendVerificationEmail() { | ||
| public function testThatResendActionFailsWhenBadAjaxNonce() { |
There was a problem hiding this comment.
This is just splitting tests out, not changing what's actually being tested. Also removes the mocked method in favor of a mocked HTTP response.
damieng
approved these changes
Dec 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
WP_Auth0_Email_Verification::init()WP_Auth0_Email_Verification::resend_verification_email()(merged withwp_auth0_ajax_resend_verification_email())WP_Auth0_Email_Verification::ajax_resend_email()Testing
Checklist