-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove class WP-Auth0 and move methods to functions #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
changed the title
Remove deprecated from wp auth0
Remove class WP-Auth0 and move methods to functions
Dec 20, 2019
joshcanhelp
force-pushed
the
remove-deprecated-from-wp-auth0
branch
from
December 20, 2019 20:15
2262c82
to
9a9fc0c
Compare
lbalmaceda
reviewed
Dec 26, 2019
lbalmaceda
approved these changes
Dec 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
WP_Auth0
WP_Auth0::ready()
towp_auth0_is_ready()
WP_Auth0::get_tenant_region()
towp_auth0_get_tenant_region()
WP_Auth0::get_tenant()
towp_auth0_get_tenant()
WP_Auth0::render_back_to_auth0()
toWP_Auth0_Lock::render_back_to_lock()
Note to reviewers: This PR is piecing the
WP_Auth0
class into functions. I would recommend going commit by commit for this review. The diff forWP_Auth0.php
did not come out well so if you're looking at the changed file, lines ~40 - 285 are all new.Testing
Checklist