Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove future iat check #757

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Remove future iat check #757

merged 1 commit into from
Jan 8, 2020

Conversation

joshcanhelp
Copy link
Contributor

Changes

Remove iat claim value check for ID token validation; continue to check for presence.

Testing

  • This modifies test coverage
  • This change was created in PHP 7.2

Checklist

  • All existing and new tests complete without errors.
  • The correct base branch is being used.

@joshcanhelp joshcanhelp requested a review from a team January 7, 2020 23:02
@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Jan 7, 2020
damieng
damieng approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@damieng damieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing there was no test coverage.

@joshcanhelp
Copy link
Contributor Author

@damieng - It's a copy of what's in the PHP SDK, will be extracted out to a separate library.

@joshcanhelp joshcanhelp merged commit 52455fc into master Jan 8, 2020
@joshcanhelp joshcanhelp deleted the remove-iat-future-check branch January 8, 2020 02:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @damieng