Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass shortcode atts to the handler #789

Merged
merged 1 commit into from
May 4, 2020

Conversation

drobin03
Copy link
Contributor

Description

In 4.0.0 the "[auth0]" shortcode no longer accepts parameters (i.e "redirect_to"), this looks like it was an accidental bug introduced during a rewrite.

Testing

Verified locally that the redirect_to shortcode now works. Also compared to v3.11 to be sure that this used to be supported.

@drobin03 drobin03 requested a review from a team April 30, 2020 19:46
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drobin03 - Appreciate the PR here! It looks like you're right, the original method was passing that before (as it should):

https://github.com/auth0/wp-auth0/blob/3.11.3/WP_Auth0.php#L355

Let me get a few tests in here, address your other issue, and we'll get a patch release out as soon as possible.

@joshcanhelp joshcanhelp added this to the 4.1.0 milestone May 4, 2020
@drobin03
Copy link
Contributor Author

drobin03 commented May 4, 2020

Sounds great. Thanks @joshcanhelp!

@joshcanhelp
Copy link
Contributor

❯ composer test
> "vendor/bin/phpunit"
Installing...
Running as single site... To run multisite, use -c tests/phpunit/multisite.xml
Not running ajax tests. To execute these, use --group ajax.
Not running ms-files tests. To execute these, use --group ms-files.
Not running external-http tests. To execute these, use --group external-http.
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.2.28 with Xdebug 2.6.0
Configuration: ~/Sites/wp-auth0/wp-content/plugins/auth0/phpunit.xml.dist

...............................................................  63 / 409 ( 15%)
............................................................... 126 / 409 ( 30%)
............................................................... 189 / 409 ( 46%)
............................................................... 252 / 409 ( 61%)
............................................................... 315 / 409 ( 77%)
............................................................... 378 / 409 ( 92%)
...............................                                 409 / 409 (100%)

Time: 23.19 seconds, Memory: 48.25MB

OK (409 tests, 1561 assertions)

~/Sites/wp-auth0/wp-content/plugins/auth0 4.0_fix_shortcode_atts 24s
❯ snyk test

Testing ~/Sites/wp-auth0/wp-content/plugins/auth0...

Organization:      auth0-sdks
Package manager:   composer
Target file:       composer.lock
Project name:      auth0/wp-auth0
Open source:       no
Project path:      ~/Sites/wp-auth0/wp-content/plugins/auth0
Licenses:          enabled

✓ Tested 4 dependencies for known issues, no vulnerable paths found.

Next steps:
- Run `snyk monitor` to be notified about new related vulnerabilities.
- Run `snyk test` as part of your CI/test.

@joshcanhelp joshcanhelp merged commit 5ac53d5 into auth0:master May 4, 2020
@joshcanhelp joshcanhelp mentioned this pull request May 4, 2020
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants