Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the client ID and redirect URI used in the setup wizard #794

Merged
merged 2 commits into from
May 20, 2020

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented May 19, 2020

Description

Fix mis-matched auth code exchange parameters, causing the setup wizard to fail on some sites where the site_url does not match the home_url.

Note to reviewers: Ignore POT, PO, and MO files, minor change in translation

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@joshcanhelp joshcanhelp force-pushed the ESD-6255-fix-setup-wizard-auth-code-params branch from 5aedaf0 to 71db540 Compare May 19, 2020 04:03
@joshcanhelp joshcanhelp added this to the 4.1.0 milestone May 19, 2020
@@ -7,7 +7,7 @@
<p class="a0-step-text"><?php _e( 'Adjust the plugin settings from the WordPress dashboard, and visit the Auth0 dashboard to change how users log in, add connections, enable multi-factor authentication, and more.', 'wp-auth0' ); ?></p>

<div class="a0-buttons extra-space">
<a href="<?php echo admin_url( 'admin.php?page=wpa0' ); ?>" class="button button-primary"><?php _e( 'GO TO PLUGIN SETTINGS', 'wp-auth0' ); ?></a>
<a href="<?php echo admin_url( 'admin.php?page=wpa0' ); ?>" class="button button-primary"><?php _e( 'Go To Plugin Settings', 'wp-auth0' ); ?></a>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation change here, caps only

@joshcanhelp joshcanhelp marked this pull request as ready for review May 19, 2020 04:10
@joshcanhelp joshcanhelp requested a review from a team May 19, 2020 04:10
@joshcanhelp joshcanhelp mentioned this pull request May 19, 2020
@jimmyjames jimmyjames requested review from jimmyjames and removed request for a team May 19, 2020 19:39
Copy link

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@joshcanhelp joshcanhelp merged commit 9afeb4f into master May 20, 2020
@joshcanhelp joshcanhelp deleted the ESD-6255-fix-setup-wizard-auth-code-params branch May 20, 2020 03:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants