Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce static analysis #813

Closed
wants to merge 5 commits into from
Closed

Conversation

szepeviktor
Copy link
Contributor

Description

Run PHPStan in CI

References

#785

Testing

Ci does it.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jan 9, 2021

Could anyone help me fix the rest of errors ❔

@evansims
Copy link
Member

evansims commented Feb 2, 2021

Hey @szepeviktor 👋 Thanks for your work on this! I know you have this marked as a draft, but I went ahead and merged a lot of your valuable efforts here into master as I was already in the process of cleaning things up. I've merged those changes from master back to this PR to bring it up to date as a result. Will give you complete credit for your efforts here in the changelog, of course, it's really so appreciated!

Did you have additional efforts you wanted to pursue in this PR that we should leave it open for? Happy to do so, just wanted to check! Thank you again

@szepeviktor
Copy link
Contributor Author

Thank you very much for your kind response.
This PR is actually an inspiration.
Please include PHPStan in your CI if you see its huge benefit.

@szepeviktor szepeviktor marked this pull request as ready for review February 2, 2021 16:05
@szepeviktor szepeviktor closed this Feb 2, 2021
@szepeviktor szepeviktor deleted the patch-1 branch February 2, 2021 16:05
@evansims evansims added this to the 4.2.0 milestone Feb 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants