Complete account linking in authflow #4159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tung2744
commented
Apr 23, 2024
…ype of account linking
tung2744
commented
Apr 23, 2024
pkg/lib/authenticationflow/declarative/intent_check_conflict_and_create_identity.go
Outdated
Show resolved
Hide resolved
tung2744
changed the title
|
Ready for review, |
tung2744
commented
Apr 24, 2024
| @@ -74,7 +74,7 @@ func (i *IntentSignupFlowStepIdentify) GetVerifiableClaims(_ context.Context, _ | |||
| return nil, nil | |||
| } | |||
|
|
|||
| m, ok := authflow.FindMilestoneInCurrentFlow[MilestoneDoCreateIdentity](flows.Nearest) | |||
| m, ok := authflow.FindFirstMilestone[MilestoneDoCreateIdentity](flows.Nearest) | |||
There was a problem hiding this comment.
It seems using milestone with nested steps could easily cause bugs, I am thinking about should we redefine milestone as "node / intent created by this intent". i.e. We always search in flows.Nearest only.
There was a problem hiding this comment.
Sure. I think we need to review the existing usage of milestone, and classify each usage into different groups. If we only have a group ("node / intent created by this intent"), then we can change the behavior.
There was a problem hiding this comment.
Created an issue https://linear.app/authgear/issue/DEV-1245/revise-usage-of-milestones-in-authflow for this
pkg/lib/authenticationflow/declarative/node_create_identity_login_id.go
Outdated
Show resolved
Hide resolved
pkg/lib/authenticationflow/declarative/utils_account_linking.go
Outdated
Show resolved
Hide resolved
louischan-oursky
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #4134 #4146
ref DEV-1223 DEV-1231