Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor oauth relying party code #4208

Merged
merged 30 commits into from May 14, 2024
Merged

Refactor oauth relying party code #4208

merged 30 commits into from May 14, 2024

Conversation

louischan-oursky
Copy link
Collaborator

@louischan-oursky louischan-oursky commented May 9, 2024 •
edited by tung2744

ref DEV-1263

@louischan-oursky louischan-oursky changed the title Refactor oauth relying party code [WIP] Refactor oauth relying party code May 9, 2024
@louischan-oursky louischan-oursky force-pushed the dev-1263-refactor-oauth branch 3 times, most recently from a139da5 to d9ed2bb Compare May 13, 2024 06:16
@louischan-oursky louischan-oursky changed the title [WIP] Refactor oauth relying party code Refactor oauth relying party code May 13, 2024
@louischan-oursky louischan-oursky marked this pull request as ready for review May 13, 2024 06:16
@louischan-oursky
Copy link
Collaborator Author

@tung2744 Ready for review

@louischan-oursky louischan-oursky force-pushed the dev-1263-refactor-oauth branch 2 times, most recently from 687ac4d to 86950d4 Compare May 13, 2024 06:53
@louischan-oursky
Move OAuth provider config to a separate package
29ead28
@louischan-oursky
Move access_token.go to oauthrelyingpartyutil
d779046
@louischan-oursky
Move user_profile.go to oauthrelyingpartyutil
d4c7a17
@louischan-oursky
Move authurl.go to oauthrelyingpartyutil
1bf0236
@louischan-oursky
Remove dependency on pkg/lib/config in legacy implementations
dfece4f
@louischan-oursky
Remove unnecessary interfaces NonOpenIDConnectProvider and OpenIDConn…
c567882 
…ectProvider
@louischan-oursky
Remove GetPrompt from the interface
234f9c0 
This method is an implementation details of the provider.
@louischan-oursky
Rename GetAuthURL to GetAuthorizationURL
176752a
@louischan-oursky
Move GetAuthorizationURLOptions to oauthrelyingparty
5d55032
@louischan-oursky
Merge OAuthAuthorizationResponse into GetAuthInfoParam
120cffb
@louischan-oursky
Rename GetAuthInfo to GetUserProfile
8b11031
@louischan-oursky
Avoid using stdattrs.T in UserProfile
20ff1b2
@louischan-oursky
Call NewOAuthProvider as late as possible
edef218
@louischan-oursky
Move GetUserProfileOptions and UserProfile to oauthrelyingparty
44cab8c
@louischan-oursky
Change OAuthProviderFactory to work like a provider
555612e
@louischan-oursky
Remove Config() from OAuthProvider
ca5c558
@louischan-oursky
Move standard attributes normalization out of OAuthProvider
2646883
@louischan-oursky
Remove all fields from implementation structs
b20bbc7
@louischan-oursky
Move wechat_authinfo to wechat
afe5eb2
@louischan-oursky
Copy link
Collaborator Author

Rebased on latest main

@tung2744
Copy link
Contributor

e2e tests are failing with panic: oauth provider not in registry

@louischan-oursky
Copy link
Collaborator Author

Fixed.

@tung2744 tung2744 merged commit a786b95 into authgear:main May 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tung2744 tung2744 tung2744 approved these changes

Assignees

@tung2744 tung2744

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@louischan-oursky @tung2744