Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor oauth relying party code #4208

Merged
merged 30 commits into from
May 14, 2024
Merged

Refactor oauth relying party code #4208

merged 30 commits into from
May 14, 2024

Commits on May 14, 2024

  1. Move OAuth provider config to a separate package

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    29ead28 View commit details
    Browse the repository at this point in the history

  2. Move access_token.go to oauthrelyingpartyutil

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d779046 View commit details
    Browse the repository at this point in the history

  3. Move user_profile.go to oauthrelyingpartyutil

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d4c7a17 View commit details
    Browse the repository at this point in the history

  4. Move authurl.go to oauthrelyingpartyutil

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    1bf0236 View commit details
    Browse the repository at this point in the history

  5. Remove dependency on pkg/lib/config in legacy implementations

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    dfece4f View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary interfaces NonOpenIDConnectProvider and OpenIDConn… 

    …ectProvider
    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c567882 View commit details
    Browse the repository at this point in the history

  7. Remove GetPrompt from the interface 

    This method is an implementation details of the provider.
    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    234f9c0 View commit details
    Browse the repository at this point in the history

  8. Rename GetAuthURL to GetAuthorizationURL

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    176752a View commit details
    Browse the repository at this point in the history

  9. Move GetAuthorizationURLOptions to oauthrelyingparty

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    5d55032 View commit details
    Browse the repository at this point in the history

  10. Merge OAuthAuthorizationResponse into GetAuthInfoParam

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    120cffb View commit details
    Browse the repository at this point in the history

  11. Rename GetAuthInfo to GetUserProfile

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8b11031 View commit details
    Browse the repository at this point in the history

  12. Avoid using stdattrs.T in UserProfile

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    20ff1b2 View commit details
    Browse the repository at this point in the history

  13. Call NewOAuthProvider as late as possible

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    edef218 View commit details
    Browse the repository at this point in the history

  14. Move GetUserProfileOptions and UserProfile to oauthrelyingparty

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    44cab8c View commit details
    Browse the repository at this point in the history

  15. Change OAuthProviderFactory to work like a provider

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    555612e View commit details
    Browse the repository at this point in the history

  16. Remove Config() from OAuthProvider

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    ca5c558 View commit details
    Browse the repository at this point in the history

  17. Move standard attributes normalization out of OAuthProvider

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    2646883 View commit details
    Browse the repository at this point in the history

  18. Remove all fields from implementation structs

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b20bbc7 View commit details
    Browse the repository at this point in the history

  19. Move wechat_authinfo to wechat

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    afe5eb2 View commit details
    Browse the repository at this point in the history

  20. Move oidc.go to oauthrelyingpartyutil

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    76c8233 View commit details
    Browse the repository at this point in the history

  21. Move implementations to oauthrelyingparty

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    6b2a401 View commit details
    Browse the repository at this point in the history

  22. Import provider in tests 

    So that they are registered.
    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    1e4cb06 View commit details
    Browse the repository at this point in the history

  23. Workaround import cycle

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d4d45d3 View commit details
    Browse the repository at this point in the history

  24. Hide Scope() in interface

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    4f1d67e View commit details
    Browse the repository at this point in the history

  25. Switch to depend on github.com/authgear/oauthrelyingparty

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    63345a4 View commit details
    Browse the repository at this point in the history

  26. Use goimports instead of go fmt 

    goimports can sort imports.
    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    5d3494f View commit details
    Browse the repository at this point in the history

  27. Run make fmt

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d54d90f View commit details
    Browse the repository at this point in the history

  28. Fix compilation errors after rebase

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    7ce1975 View commit details
    Browse the repository at this point in the history

  29. Move Normalizer to internalinterface to solve import cycle 

    Also removed the previous import cycle workaround.
    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    9e451b6 View commit details
    Browse the repository at this point in the history

  30. Fix oauth provider not registered in e2e executable

    @louischan-oursky
    louischan-oursky committed May 14, 2024
    Configuration menu
    Copy the full SHA
    5d13b08 View commit details
    Browse the repository at this point in the history