Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 23 env prop #24

Merged
merged 6 commits into from
Feb 4, 2018
Merged

Issue 23 env prop #24

merged 6 commits into from
Feb 4, 2018

Conversation

nirmalchandra
Copy link
Collaborator

No description provided.

@TargetEnv("app_config.properties")
@EnvProperty("${ENV_NAME}_") // see "ENV_NAME=ci" in .bash_profile file. If not found, then defaults to "app_config.properties"
@RunWith(TestOnlyZeroCodeUnitRunner.class)
public class ZeroCodeEnvPropertyReaderTest {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, nice, good one !

Where is the similar test for package runner?
Can you please add an integration test for package/suite runner?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test. Look for org.jsmart.zerocode.core.envprop.suite.ZeroCodeEnvPropertyReaderPackageTest

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nirmalchandra nirmalchandra merged commit ed2cb97 into master Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants