ISSUE-601 # Resolve JSON.CONTENT as object or array

[vivektiwary]

Fixes Issue: #601

PR Branch
#ADD LINK TO THE PR BRANCH

Motivation and Context

Checklist:

• Unit tests added

• Integration tests added

• Test names are meaningful

• Feature manually tested

• Branch build passed

• No 'package.*' in the imports

• Relevant Wiki page updated with clear instruction for the end user

  • Not applicable. This was only a refactor change, no functional or behaviour changes were introduced

• Http test added to http-testing module(if applicable) ?

  • Not applicable. The changes did not affect HTTP automation flow

• Kafka test added to kafka-testing module(if applicable) ?

  • Not applicable. The changes did not affect Kafka automation flow

[authorjapps]

Hello @vivektiwary , Hope you're well. Thanks for the PR. Looking great from impl point of view.

Can you please take care of a few more things in the PR?

1

Can you please add some tests as I couldn't find any in the PR ?
You can look and follow the tests how they are written for "JSON.FILE:".
Please add:
a) Unit tests (top priority)
b) Integration tests (next priority)

2

Once added, please tick the following checkboxes encircled.

[authorjapps]

Can you please add some Unit tests?

Then, add integration tests after that.

[vivektiwary]

Hi, I opened it as a draft for my reference. I am adding the test cases as well. I will remove the draft status after adding the tests. Thank you Vivek

…

On Sat, 16 Dec 2023 at 6:29 PM authorjapps ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In core/src/main/java/org/jsmart/zerocode/core/engine/tokens/ZeroCodeValueTokens.java <#612 (comment)>: > @@ -31,6 +31,8 @@ public class ZeroCodeValueTokens { public static final String SYSTEM_ENV = "SYSTEM.ENV:"; public static final String $VALUE = ".$VALUE"; public static final String ABS_PATH = "ABS.PATH:"; + public static final String JSON_CONTENT = "JSON.CONTENT:"; Can you please add some Unit tests? Then, add integration tests after that. — Reply to this email directly, view it on GitHub <#612 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGACIWDOQLEJTUEJIYHKGLYJWLJFAVCNFSM6AAAAABAW2P4B6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBVGE3TKOJVGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[vivektiwary]

I have added a few Unit test cases, working on some more. Then I will add the integration test cases as well.

[authorjapps]

I have added a few Unit test cases, working on some more. Then I will add the integration test cases as well.

Sounds great.
Just have a watch on the "Checks" tab for CI status after your commits.
CI Link: https://github.com/authorjapps/zerocode/pull/612/checks

[vivektiwary]

@authorjapps this PR is now ready for review.

[authorjapps]

@vivektiwary , can you look at the build failures and get them fixed?
Thanks in advance