-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-601 # Resolve JSON.CONTENT as object or array #612
Conversation
Hello @vivektiwary , Hope you're well. Thanks for the PR. Looking great from impl point of view. Can you please take care of a few more things in the PR? 1Can you please add some tests as I couldn't find any in the PR ? 2 |
@@ -31,6 +31,8 @@ public class ZeroCodeValueTokens { | |||
public static final String SYSTEM_ENV = "SYSTEM.ENV:"; | |||
public static final String $VALUE = ".$VALUE"; | |||
public static final String ABS_PATH = "ABS.PATH:"; | |||
public static final String JSON_CONTENT = "JSON.CONTENT:"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add some Unit tests?
Then, add integration tests after that.
Hi,
I opened it as a draft for my reference. I am adding the test cases as
well. I will remove the draft status after adding the tests.
Thank you
Vivek
…On Sat, 16 Dec 2023 at 6:29 PM authorjapps ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
core/src/main/java/org/jsmart/zerocode/core/engine/tokens/ZeroCodeValueTokens.java
<#612 (comment)>:
> @@ -31,6 +31,8 @@ public class ZeroCodeValueTokens {
public static final String SYSTEM_ENV = "SYSTEM.ENV:";
public static final String $VALUE = ".$VALUE";
public static final String ABS_PATH = "ABS.PATH:";
+ public static final String JSON_CONTENT = "JSON.CONTENT:";
Can you please add some Unit tests?
Then, add integration tests after that.
—
Reply to this email directly, view it on GitHub
<#612 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGACIWDOQLEJTUEJIYHKGLYJWLJFAVCNFSM6AAAAABAW2P4B6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBVGE3TKOJVGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I have added a few Unit test cases, working on some more. Then I will add the integration test cases as well. |
Sounds great. |
@authorjapps this PR is now ready for review. |
@vivektiwary , can you look at the build failures and get them fixed? |
Fixes Issue: #601
PR Branch
#ADD LINK TO THE PR BRANCH
Motivation and Context
Checklist:
Unit tests added
Integration tests added
Test names are meaningful
Feature manually tested
Branch build passed
No 'package.*' in the imports
Relevant Wiki page updated with clear instruction for the end user
Http test added to
http-testing
module(if applicable) ?Kafka test added to
kafka-testing
module(if applicable) ?