Strengthen the validation regexs on object IDs #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not properly checking that the *entire* ID matches the regex Fixes authzed/spicedb#407
ecordell
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Discussed offline: This is technically a backwards-incompatible change, but if data was written against this validation that would start to fail after this merges, then that data was already in a state that prevented it from being used in all of the current APIs.
There may be some time that this validation is relaxed, but for now we just want it to be consistent.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not properly checking that the entire ID matches the regex
Fixes authzed/spicedb#407