more specific relationship filters #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakedt
force-pushed
the
better-filters
branch
2 times, most recently
from
452cb5c
to
5f80710
Compare
jzelinskie
reviewed
Sep 22, 2021
| message SubjectFilter { | ||
| message RelationFilter { | ||
| string relation = 1 [ (validate.rules).string = { | ||
| pattern : "^[a-z][a-z0-9_]{2,62}[a-z0-9]$", |
There was a problem hiding this comment.
this needs to be able to be empty string
jakedt
force-pushed
the
better-filters
branch
from
5f80710
to
d72337e
Compare
| @@ -76,33 +76,50 @@ message Consistency { | |||
| // RelationshipFilter is a collection of filters which when applied to a | |||
| // relationship will return relationships that have exactly matching fields. | |||
| // | |||
| // resource_filter is required. All other fields are optional and if left | |||
| // object_type is required. All other fields are optional and if left | |||
Signed-off-by: Jake Moshenko <jacob.moshenko@gmail.com>
jakedt
force-pushed
the
better-filters
branch
from
d72337e
to
cd09922
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.