Add relationships filtering to bulk export, delete and watch APIs and expand the filtering support #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephschorr
force-pushed
the
filtering-improvements
branch
2 times, most recently
from
596ca3e
to
ceba4ce
Compare
… expand the filtering support
josephschorr
force-pushed
the
filtering-improvements
branch
from
ceba4ce
to
68857c7
Compare
ecordell
reviewed
Feb 2, 2024
| message RelationshipFilter { | ||
| // resource_type is the *optional* resource type of the relationship. | ||
| // NOTE: It is not prefixed with "optional_" for legacy compatibility. |
There was a problem hiding this comment.
it's the number 1 that provides the compatibility, right? are you concerned about the generated client APIs changing?
There was a problem hiding this comment.
Yeah, I'm concerned it'll break existing client code
There was a problem hiding this comment.
It shouldn't break existing client code, it would break when someone updates their version and finds codegen changed the field name
There was a problem hiding this comment.
That's what I meant, but it is still a "breaking" change in the sense that moving a minor version of the client library could break existing callers. We'd either have to major version all the client libraries or just not change it
vroldanbet
approved these changes
Feb 5, 2024
ecordell
approved these changes
Feb 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.