disables dispatch for memory datastore #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you should also not announce the service: I think also gateway needs some fix, because following the tutorial the service announces it, but it has no backend. I've filed a new bug for that (#113). |
|
@ensonic thanks for opening the issue, that makes sense to me! |
jzelinskie
reviewed
Nov 25, 2022
pkg/config/config_test.go
Outdated
Comment on lines
1268
to
1270
| parts := strings.Split(env, "=") | ||
| name := parts[0] | ||
| value := parts[1] |
There was a problem hiding this comment.
strings.Cut might be perfect here
|
@samkim mind having a look at the failing Ginko tests? 🙏🏻 |
|
I've patched in the CL (see #114) and now I get: |
My bad. When I build from the PR, I had to restart the spicedb-operator deployment (set image was not enough). |
vroldanbet
force-pushed
the
disable-dispatch-memory-ds
branch
2 times, most recently
from
68a5069
to
230c186
Compare
fixes #111 users running the repository example where stuck because the SpiceDB instance spun up had Dispatch API server disabled, but actual dispatching enabled, so Check requests errored out. This adds tests to verify the untested method ToEnvVarApplyConfiguration() and makes sure memory datastore does not set dispatchUpstreamAddr Co-authored-by: Sam Kim <sam@authzed.com>
samkim
force-pushed
the
disable-dispatch-memory-ds
branch
from
230c186
to
14cd210
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #111
users running the repository example where stuck because the SpiceDB instance spun up had Dispatch API server disabled, but actual dispatching enabled, so
Checkrequests errored out.This adds tests to verify the untested method
ToEnvVarApplyConfiguration()and makes sure memory datastore does not set dispatchUpstreamAddr