Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory usage of WriteSchema #1743

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

josephschorr
Copy link
Member

We now only annotate the namespaces that have been changed or added, as annotation and canonicalization uses a significant amount of memory

@josephschorr josephschorr requested a review from a team as a code owner February 8, 2024 20:09
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Feb 8, 2024
We now only annotate the namespaces that have been changed or added, as annotation and canonicalization uses a significant amount of memory
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you perhaps write a benchmark that compares allocations before and after with a large schema?

@josephschorr
Copy link
Member Author

@vroldanbet I could but I verified it manually; not sure we really need this continuously tested

@josephschorr josephschorr added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
@josephschorr josephschorr added this pull request to the merge queue Feb 9, 2024
Merged via the queue into authzed:main with commit a32213b Feb 9, 2024
20 checks passed
@josephschorr josephschorr deleted the writeschema-memory branch February 9, 2024 20:06
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants