Add Must* methods for any methods that can panic in tuple pkg #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephschorr
force-pushed
the
must-tuple
branch
from
f0d3cd8
to
d3d67b0
Compare
github-actions
bot
added
area/api v0
ecordell
reviewed
Oct 7, 2021
| return String(FromRelationship(tpl)) | ||
| // MustRelString converts a relationship into a string. | ||
| func MustRelString(tpl *v1.Relationship) string { | ||
| return String(MustFromRelationship(tpl)) | ||
| } |
There was a problem hiding this comment.
What about a non-Must RelString?
There was a problem hiding this comment.
No one used the non-Must version, so I didn't keep it
There was a problem hiding this comment.
Added back in as discussed
Fixes #131 Signed-off-by: Joseph Schorr <josephschorr@users.noreply.github.com>
josephschorr
force-pushed
the
must-tuple
branch
from
d3d67b0
to
061db12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131