Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix panicking functions in tuple package with "Must" #131

Closed
jzelinskie opened this issue Sep 27, 2021 · 0 comments · Fixed by #176
Closed

Prefix panicking functions in tuple package with "Must" #131

jzelinskie opened this issue Sep 27, 2021 · 0 comments · Fixed by #176
Labels
hint/good first issue Someone new could handle this kind/tech debt Addresses legacy code/decisions priority/4 maybe This might get done someday

Comments

@jzelinskie
Copy link
Member

jzelinskie commented Sep 27, 2021 •
edited
Loading

There are functions in the tuple package that panic when the invalid input is provided.
These functions should be renamed to have the prefix Must in front of them in order to follow the Go convention.
@jzelinskie jzelinskie added hint/good first issue Someone new could handle this priority/4 maybe This might get done someday kind/tech debt Addresses legacy code/decisions labels Sep 27, 2021
@jzelinskie jzelinskie changed the title Rename string parsing functions in tuple package to "MustParse" Prefix string parsing function names in tuple package with "Must" Sep 27, 2021
@jzelinskie jzelinskie changed the title Prefix string parsing function names in tuple package with "Must" Prefix function names in tuple package with "Must" Sep 27, 2021
@jzelinskie jzelinskie changed the title Prefix function names in tuple package with "Must" Prefix panicking function names in tuple package with "Must" Sep 27, 2021
@jzelinskie jzelinskie changed the title Prefix panicking function names in tuple package with "Must" Prefix panicking functions in tuple package with "Must" Sep 27, 2021
josephschorr added a commit that referenced this issue Oct 6, 2021
@josephschorr
Add Must* methods for any methods that can panic in tuple pkg
f0d3cd8 
Fixes #131
@josephschorr josephschorr mentioned this issue Oct 6, 2021
Merged
josephschorr added a commit that referenced this issue Oct 6, 2021
@josephschorr
Add Must* methods for any methods that can panic in tuple pkg
d3d67b0 
Fixes #131

Signed-off-by: Joseph Schorr <josephschorr@users.noreply.github.com>
josephschorr added a commit that referenced this issue Oct 7, 2021
@josephschorr
Add Must* methods for any methods that can panic in tuple pkg
061db12 
Fixes #131

Signed-off-by: Joseph Schorr <josephschorr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hint/good first issue Someone new could handle this kind/tech debt Addresses legacy code/decisions priority/4 maybe This might get done someday
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Must* methods for any methods that can panic in tuple pkg authzed/spicedb
1 participant
@jzelinskie