Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint common #3337

Merged
merged 1 commit into from Jun 21, 2023
Merged

lint common #3337

merged 1 commit into from Jun 21, 2023

Conversation

yinweisu
Copy link
Collaborator

Issue #, if available:

Description of changes:

  • apply black and isort to the common module

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yinweisu yinweisu requested a review from Innixma June 20, 2023 20:50
@github-actions
Copy link

Job PR-3337-99ba7b7 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3337/99ba7b7/index.html

Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines -153 to +11
(
["dummy"],
None,
None,
["dummy"]
)
({"dummy": {}}, ["dummy"], None, {"dummy": {}}),
({"dummy": {"dummy": 1}}, ["dummy"], None, {"dummy": {"dummy": 1}}),
({"dummy": {}}, ["foo"], None, {}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit sad about this reformatting, but I suppose it is a small price to pay overall.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@Innixma Innixma added this to the 0.9 Release milestone Jun 21, 2023
@yinweisu yinweisu merged commit ecbae91 into autogluon:master Jun 21, 2023
28 checks passed
@yinweisu yinweisu deleted the lint_common branch June 21, 2023 00:41
ddelange added a commit to ddelange/autogluon that referenced this pull request Jun 22, 2023
* 'master' of https://github.com/awslabs/autogluon:
  [AutoMM] Remove fairscale (autogluon#3342)
  lint core (autogluon#3339)
  Move PyMuPDF to optional (autogluon#3331)
  Add community section to website front page (autogluon#3333)
  lint common (autogluon#3337)
  Remove TIMM in core setup (autogluon#3334)
  Update persist_models max_memory 0.1 -> 0.4 (autogluon#3338)
  Update google analytics property (autogluon#3330)
  Add Discord Link (autogluon#3332)
  0.8 post release (autogluon#3322)
@Innixma Innixma modified the milestones: 0.9 Release, 1.0 Release Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants