Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoMM] Remove fairscale #3342

Merged
merged 1 commit into from Jun 21, 2023
Merged

[AutoMM] Remove fairscale #3342

merged 1 commit into from Jun 21, 2023

Conversation

zhiqiangdon
Copy link
Contributor

@zhiqiangdon zhiqiangdon commented Jun 21, 2023 •
edited

Issue #, if available:

Description of changes:
Remove fairescale as lightning has deprecated using it since v1.9.0.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zhiqiangdon zhiqiangdon requested a review from tonyhoo June 21, 2023 18:11
tonyhoo
tonyhoo approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@tonyhoo tonyhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please make sure all tests pass

@github-actions
Copy link

Job PR-3342-d7e7ec1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3342/d7e7ec1/index.html

@zhiqiangdon zhiqiangdon merged commit 9703f24 into autogluon:master Jun 21, 2023
28 checks passed
ddelange added a commit to ddelange/autogluon that referenced this pull request Jun 22, 2023
@ddelange
Merge branch 'master' of https://github.com/awslabs/autogluon into cp311
650cc81 
* 'master' of https://github.com/awslabs/autogluon:
  [AutoMM] Remove fairscale (autogluon#3342)
  lint core (autogluon#3339)
  Move PyMuPDF to optional (autogluon#3331)
  Add community section to website front page (autogluon#3333)
  lint common (autogluon#3337)
  Remove TIMM in core setup (autogluon#3334)
  Update persist_models max_memory 0.1 -> 0.4 (autogluon#3338)
  Update google analytics property (autogluon#3330)
  Add Discord Link (autogluon#3332)
  0.8 post release (autogluon#3322)
@zhiqiangdon zhiqiangdon deleted the mm-install branch June 29, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyhoo tonyhoo tonyhoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhiqiangdon @tonyhoo