Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update persist_models max_memory 0.1 -> 0.4 #3338

Merged
merged 1 commit into from Jun 21, 2023
Merged

Update persist_models max_memory 0.1 -> 0.4 #3338

merged 1 commit into from Jun 21, 2023

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented Jun 20, 2023 •
edited

Issue #, if available:

Description of changes:
Update persist_models max_memory 0.1 -> 0.4

0.4 is a safe memory amount to persist with, as confirmed on AMLB.
This results in an average 2x batch_size=1 inference speedup for best_quality preset with no drawbacks.

(06_11is with `max_memory=0.1` , 06_19 is with `max_memory=0.4`)

AutoGluon_bq_1h8c_2023_06_11 | rows_per_s_mean=0.22 | rows_per_s_median=0.39
AutoGluon_bq_1h8c_2023_06_19 | rows_per_s_mean=0.35 | rows_per_s_median=0.65

AutoGluon_hq_1h8c_2023_06_11 | rows_per_s_mean=3.56 | rows_per_s_median=10.08
AutoGluon_hq_1h8c_2023_06_19 | rows_per_s_mean=5.61 | rows_per_s_median=9.84

AutoGluon_hq_il001_1h8c_2023_06_11 | rows_per_s_mean=6.9 | rows_per_s_median=37.52
AutoGluon_hq_il001_1h8c_2023_06_19 | rows_per_s_mean=12.13 | rows_per_s_median=38.26

AutoGluon_mq_1h8c_2023_06_11 | rows_per_s_mean=9.51 | rows_per_s_median=23.11
AutoGluon_mq_1h8c_2023_06_19 | rows_per_s_mean=9.94 | rows_per_s_median=21.58

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Innixma Innixma added this to the 0.9 Release milestone Jun 20, 2023
@Innixma Innixma requested a review from yinweisu June 20, 2023 21:44
@Innixma Innixma mentioned this pull request Jun 20, 2023
Merged
yinweisu
yinweisu approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@yinweisu yinweisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Job PR-3338-50d85e8 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3338/50d85e8/index.html

@Innixma Innixma merged commit 362bb7a into autogluon:master Jun 21, 2023
28 checks passed
ddelange added a commit to ddelange/autogluon that referenced this pull request Jun 22, 2023
@ddelange
Merge branch 'master' of https://github.com/awslabs/autogluon into cp311
650cc81 
* 'master' of https://github.com/awslabs/autogluon:
  [AutoMM] Remove fairscale (autogluon#3342)
  lint core (autogluon#3339)
  Move PyMuPDF to optional (autogluon#3331)
  Add community section to website front page (autogluon#3333)
  lint common (autogluon#3337)
  Remove TIMM in core setup (autogluon#3334)
  Update persist_models max_memory 0.1 -> 0.4 (autogluon#3338)
  Update google analytics property (autogluon#3330)
  Add Discord Link (autogluon#3332)
  0.8 post release (autogluon#3322)
@Innixma Innixma modified the milestones: 0.9 Release, 1.0 Release Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinweisu yinweisu yinweisu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Innixma @yinweisu