-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme Check #42
Comments
A couple of these recommendations are already taken care of in the theme -- Theme Check is finding the back compat for the old custom header image API for example. As for some of the others -- they would probably bloat _s. Some are not really necessary for every theme (editor styles, for example). Which is closer to the goal that _s is trying to hit. Not trying to cover every edge case, but the most number of common cases for the most number of people. |
|
Great thanks guys, glad to knows its more issues with the plugin flagging backwards compatibility rather than the theme itself. Thanks! |
Ran this theme through Theme Check http://wordpress.org/extend/plugins/theme-check/
Found this error: WARNING: Found wrong tag, remove from your style.css header.
And these recommendations:
RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
RECOMMENDED: No reference to add_theme_support( 'custom-background', $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
RECOMMENDED: could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.
RECOMMENDED: get_current_theme found in the file inc/theme-options/theme-options.php. Deprecated since version 3.4. Use wp_get_theme() instead.
Line 256:
RECOMMENDED: add_custom_image_header found in the file inc/custom-header.php. Deprecated since version 3.4. Use add_theme_support( 'custom-header', $args ) instead.
Line 56: add_custom_image_header( $args['wp-head-callback'], $args['admin-head-callb
Since _s is by Auttomatic and suppose to be the ideal coding standards for WordPress having 0 recommendations would is probably desired.
The text was updated successfully, but these errors were encountered: