Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block support to bbPress emails #40

Closed
johngodley opened this issue Nov 24, 2022 · 5 comments
Closed

Add block support to bbPress emails #40

johngodley opened this issue Nov 24, 2022 · 5 comments

Comments

@johngodley
Copy link
Member

bbPress sends email notifications out, and these will need to support block content.

@lamosty
Copy link

lamosty commented Nov 25, 2022

The redesigned notification emails on WP.com support forums support block content. However, in bbPress core, there's a heavy HTML stripping with strip_tags. Basically, core bbPress emails are text only. We don't have that in the redesigned notifications emails. However, not sure what is the best course of action for bbPress core here. Push the fully redesigned notification emails to core? Probably, so that the blocks look good in the emails. But community might not like that. Or just remove the strip_tags call?

If we are going with the plugin approach for Gutenberg in bbPress core, I suppose we could add the redesigned emails there, too. However, we use a lot of internal WP.com HTML emails template building functionality so not sure how portable that is.

cc @lezama

@lezama
Copy link
Contributor

lezama commented Nov 25, 2022

If we are going with the plugin approach for Gutenberg in bbPress core, I suppose we could add the redesigned emails there, too. However, we use a lot of internal WP.com HTML emails template building functionality so not sure how portable that is.

I think we should do this and add filters to separate WPCOM only logic.

@dd32
Copy link
Member

dd32 commented Nov 28, 2022

I would personally suggest taking the almost do-nothing approach for bbPress emails.

Ensure that the plain-text generated is good-enough, while not going above-and-beyond.

That could just mean stripping Block HTML out before bbPress strips it, so bbPress gets a "clean" text, and potentially doing some nice things like decoding code blocks and adding bullet points for lists.

@johngodley
Copy link
Member Author

I've gone for a simple plain text version in #46 which replaces the content in the email with a nicer plain text version.

@johngodley
Copy link
Member Author

Closing this as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants