Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knox broken in node 0.4.1 #15

Closed
tanepiper opened this issue Feb 20, 2011 · 1 comment
Closed

knox broken in node 0.4.1 #15

tanepiper opened this issue Feb 20, 2011 · 1 comment

Comments

@tanepiper
Copy link

Upgrading from node 0.4.0 to 0.4.1, there has been a change in fs.open that breaks knox.

fs.js:195
binding.open(path, stringToFlags(flags), mode, callback);
^
TypeError: Bad argument
at Object.open (fs.js:195:11)
at new (fs.js:786:6)
at Object.createReadStream (fs.js:741:10)
at Object.readFile (fs.js:49:23)
at Client.putFile (/usr/local/lib/node/.npm/knox/0.0.2/package/lib/knox/client.js:153:6)

Had a look at the line myself and admit I can't see what's up with, but I wrote a quick seperate file test and it worked fine, so can only assume it's coming from somewhere in knox

@domenic
Copy link
Contributor

domenic commented Jul 16, 2012

If anyone's still using Node 0.4.1 and this is a problem, let me know and I'll investigate. Closing for now.

@domenic domenic closed this as completed Jul 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants