Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ads misaligned? #12

Closed
laurelfulford opened this issue Dec 9, 2019 · 2 comments · Fixed by #38
Closed

Ads misaligned? #12

laurelfulford opened this issue Dec 9, 2019 · 2 comments · Fixed by #38
Assignees
@laurelfulford
Labels
bug Something isn't working released

Comments

@laurelfulford
Copy link
Contributor

Issue raised here:

Automattic/newspack-theme#620

I tried Newspack-Ads plugin; it had one issue that the ads being inserted by the plugin were all left-aligned.

Creating an issue to investigate steps to reproduce, and fix!
@laurelfulford laurelfulford self-assigned this Dec 9, 2019
@laurelfulford laurelfulford mentioned this issue Dec 9, 2019
Closed
@laurelfulford laurelfulford added bug Something isn't working and removed needs investigation labels Dec 10, 2019
@laurelfulford
Copy link
Contributor Author

Confirmed that the ads block is aligned left (top ad), vs how the Jetpack ads block displays ads (bottom ad):

image

@claudiulodro claudiulodro mentioned this issue Apr 25, 2020
Merged
@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurelfulford laurelfulford

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ad centering in non-AMP mode Automattic/newspack-ads
2 participants
@laurelfulford @matticbot